[FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Multi-page support

Paul B Mahol onemda at gmail.com
Fri Mar 29 11:05:23 EET 2019


On 3/29/19, Nick Renieris <velocityra at gmail.com> wrote:
> Huh? No I fixed that, it's AV_OPT_TYPE_INT now.
> See the second email in this list (first was the initial patch, then
> the corrected patch).
>

You should also check max number of available pages.
And issue warning if user requested more than available and than provide some
page.

> Στις Παρ, 29 Μαρ 2019 στις 12:51 π.μ., ο/η Paul B Mahol
> <onemda at gmail.com> έγραψε:
>>
>> On 3/28/19, Nick Renieris <velocityra at gmail.com> wrote:
>> > Ok, here's a multipage tif with 3 pages, the two first are blue and
>> > the last one red:
>> > https://0x0.st/zKdB.tif
>> >
>>
>> Patch contains UINT16 opt and as is can not be applied.
>> Please fix that.
>>
>> > Στις Πέμ, 28 Μαρ 2019 στις 4:35 μ.μ., ο/η Paul B Mahol
>> > <onemda at gmail.com> έγραψε:
>> >>
>> >> On 3/28/19, Nick Renieris <velocityra at gmail.com> wrote:
>> >> > When I made the patch I did ask you on IRC whether I should upload
>> >> > something and got no answer.
>> >> >
>> >>
>> >> Please upload it, somewhere like https://0x0.st/
>> >>
>> >> > Στις Πέμ, 28 Μαρ 2019 στις 2:58 μ.μ., ο/η Nick Renieris
>> >> > <velocityra at gmail.com> έγραψε:
>> >> >>
>> >> >> I haven't, is there a specific place that it's preferred I upload it
>> >> >> to?
>> >> >>
>> >> >> Στις Πέμ, 28 Μαρ 2019 στις 1:12 μ.μ., ο/η Paul B Mahol
>> >> >> <onemda at gmail.com> έγραψε:
>> >> >> >
>> >> >> > On 3/28/19, Nick Renieris <velocityra at gmail.com> wrote:
>> >> >> > > Any news on this? Is there something I should do?
>> >> >> >
>> >> >> > Have you uploaded small tiff so this patch can be tested?
>> >> >> >
>> >> >> > >
>> >> >> > > Στις Σάβ, 23 Μαρ 2019 στις 2:54 μ.μ., ο/η Carl Eugen Hoyos
>> >> >> > > <ceffmpeg at gmail.com> έγραψε:
>> >> >> > >>
>> >> >> > >> 2019-03-23 13:34 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>> >> >> > >> > On 3/23/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> >> >> > >> >> 2019-03-23 9:11 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>> >> >> > >> >>> On 3/22/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> >> >> > >> >>>> 2019-03-22 15:50 GMT+01:00, velocityra at gmail.com
>> >> >> > >> >>>> <velocityra at gmail.com>:
>> >> >> > >> >>>>> From: Nick Renieris <velocityra at gmail.com>
>> >> >> > >> >>>>>
>> >> >> > >> >>>>> Option "-page N" (page index N starts from 1) can now
>> >> >> > >> >>>>> be used to specify which TIFF page/subfile to decode.
>> >> >> > >> >>>>
>> >> >> > >> >>>> What is the current behaviour?
>> >> >> > >> >>>> Shouldn't the decoder output all pages as for a video
>> >> >> > >> >>>> file?
>> >> >> > >> >>>
>> >> >> > >> >>> How?
>> >> >> > >> >>
>> >> >> > >> >> I would have suggested decoder flush.
>> >> >> > >>
>> >> >> > >> The word is probably "drain".
>> >> >> > >>
>> >> >> > >> > What? Can you elaborate what you think?
>> >> >> > >>
>> >> >> > >> Isn't there a return value that leads to subsequent calls of
>> >> >> > >> AVCodec->decode()?
>> >> >> > >>
>> >> >> > >> Carl Eugen
>> >> >> > >> _______________________________________________
>> >> >> > >> ffmpeg-devel mailing list
>> >> >> > >> ffmpeg-devel at ffmpeg.org
>> >> >> > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >> >> > >>
>> >> >> > >> To unsubscribe, visit link above, or email
>> >> >> > >> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> >> >> > > _______________________________________________
>> >> >> > > ffmpeg-devel mailing list
>> >> >> > > ffmpeg-devel at ffmpeg.org
>> >> >> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >> >> > >
>> >> >> > > To unsubscribe, visit link above, or email
>> >> >> > > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> >> >> > _______________________________________________
>> >> >> > ffmpeg-devel mailing list
>> >> >> > ffmpeg-devel at ffmpeg.org
>> >> >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >> >> >
>> >> >> > To unsubscribe, visit link above, or email
>> >> >> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> >> > _______________________________________________
>> >> > ffmpeg-devel mailing list
>> >> > ffmpeg-devel at ffmpeg.org
>> >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >> >
>> >> > To unsubscribe, visit link above, or email
>> >> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> >> _______________________________________________
>> >> ffmpeg-devel mailing list
>> >> ffmpeg-devel at ffmpeg.org
>> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >>
>> >> To unsubscribe, visit link above, or email
>> >> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> > _______________________________________________
>> > ffmpeg-devel mailing list
>> > ffmpeg-devel at ffmpeg.org
>> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> >
>> > To unsubscribe, visit link above, or email
>> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list