[FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Mar 29 00:22:45 EET 2019


2019-03-28 23:18 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
> On 3/28/19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2019-03-28 22:45 GMT+01:00, Carl Eugen Hoyos <ceffmpeg at gmail.com>:
>>
>>> Patch 1 is wrong.
>>>
>>> I don't understand the benchmarks
>>
>> Ok, numer 9 looks like a good idea, either send only this patch or wait
>> for another comment.
>
> Patches are big mess. Until this is fixed I not going to apply this mess.

More important is probably if you agree to the variable
renaming and code moving or not. If you don't, sending
only patch 9 (which, if the benchmarks are correct,
indeed shows a large speedup) could be resent.
Not sure where you see a "mess" in the latest patchset,
it looks quite clean once patch 1 is removed...

Carl Eugen


More information about the ffmpeg-devel mailing list