[FFmpeg-devel] [PATCH v3] qsv: fix the dangerous macro definitions

[Carl Eugen Hoyos]

2019-03-28 14:40 GMT+01:00, Zhong Li <zhong.li at intel.com>:
> Signed-off-by: Zhong Li <zhong.li at intel.com>
> Reviewed-by: Carl Eugen Hoyos <ceffmpeg at gmail.com>
> ---
>  libavcodec/qsv_internal.h | 4 ++--
>  libavfilter/qsvvpp.h      | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h
> index 394c558883..57d861d2be 100644
> --- a/libavcodec/qsv_internal.h
> +++ b/libavcodec/qsv_internal.h
> @@ -39,8 +39,8 @@
>       MFX_VERSION_MAJOR == (MAJOR) && MFX_VERSION_MINOR >= (MINOR))
>
>  #define QSV_RUNTIME_VERSION_ATLEAST(MFX_VERSION, MAJOR, MINOR) \
> -    (MFX_VERSION.Major > (MAJOR)) ||                           \
> -    (MFX_VERSION.Major == (MAJOR) && MFX_VERSION.Minor >= (MINOR))
> +    ((MFX_VERSION.Major > (MAJOR)) ||                           \
> +    (MFX_VERSION.Major == (MAJOR) && MFX_VERSION.Minor >= (MINOR)))

I wonder if this would be more readable without the parenthesis around
">" and "==" but since you are the maintainer this patch should be ok.

Carl Eugen