[FFmpeg-devel] [PATCH] configure: include pkgconfig path as vaapi header search

[Li, Zhong]

> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Timo Rothenpieler
> Sent: Monday, March 25, 2019 6:21 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] configure: include pkgconfig path as
> vaapi header search
> 
> On 20/03/2019 08:57, Zhong Li wrote:
> > Currectly just standard header path and be found, check_type/struct
> > will fail if vaapi is installed somewhere else.
> > ---
> >   configure | 18 ++++++++++--------
> >   1 file changed, 10 insertions(+), 8 deletions(-)
> >
> > diff --git a/configure b/configure
> > index eaf543df96..0e3c2d24bf 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6024,14 +6024,6 @@ check_type "windows.h d3d11.h"
> "ID3D11VideoDecoder"
> >   check_type "windows.h d3d11.h" "ID3D11VideoContext"
> >   check_type "d3d9.h dxva2api.h" DXVA2_ConfigPictureDecode
> > -D_WIN32_WINNT=0x0602
> >
> > -check_type "va/va.h va/va_dec_hevc.h"
> "VAPictureParameterBufferHEVC"
> > -check_struct "va/va.h" "VADecPictureParameterBufferVP9" bit_depth
> > -check_struct "va/va.h va/va_vpp.h" "VAProcPipelineCaps"
> > rotation_flags -check_type "va/va.h va/va_enc_hevc.h"
> "VAEncPictureParameterBufferHEVC"
> > -check_type "va/va.h va/va_enc_jpeg.h"
> "VAEncPictureParameterBufferJPEG"
> > -check_type "va/va.h va/va_enc_vp8.h"
> "VAEncPictureParameterBufferVP8"
> > -check_type "va/va.h va/va_enc_vp9.h"
> "VAEncPictureParameterBufferVP9"
> > -
> >   check_type "vdpau/vdpau.h" "VdpPictureInfoHEVC"
> >
> >   if enabled cuda_sdk; then
> > @@ -6469,6 +6461,16 @@ if enabled vaapi; then
> >       check_cpp_condition vaapi_1 "va/va.h" "VA_CHECK_VERSION(1, 0,
> 0)"
> >   fi
> >
> > +if enabled vaapi; then
> > +    check_type "va/va.h va/va_dec_hevc.h"
> "VAPictureParameterBufferHEVC"
> > +    check_struct "va/va.h" "VADecPictureParameterBufferVP9"
> bit_depth
> > +    check_struct "va/va.h va/va_vpp.h" "VAProcPipelineCaps"
> rotation_flags
> > +    check_type "va/va.h va/va_enc_hevc.h"
> "VAEncPictureParameterBufferHEVC"
> > +    check_type "va/va.h va/va_enc_jpeg.h"
> "VAEncPictureParameterBufferJPEG"
> > +    check_type "va/va.h va/va_enc_vp8.h"
> "VAEncPictureParameterBufferVP8"
> > +    check_type "va/va.h va/va_enc_vp9.h"
> "VAEncPictureParameterBufferVP9"
> > +fi
> > +
> >   if enabled_all opencl libdrm ; then
> >       check_type "CL/cl_intel.h" "clCreateImageFromFdINTEL_fn" &&
> >           enable opencl_drm_beignet
> >
> 
> Do I understand this right, that the desired effect is achieved by putting
> those check_* behind the pkgconfig check, which is in between the old and
> the new location?
> 
> If so, this looks OK to me.

Yes, you are right. Probably would better to make it clear in the commit message. 
Will update commit message and apply it during next 24 hours if nobody against.