[FFmpeg-devel] [PATCH] avformat/flvdec: added support for KUX container

Moritz Barsnick barsnick at gmx.net
Tue Mar 26 12:18:20 EET 2019


On Tue, Mar 26, 2019 at 00:24:40 +0100, Carl Eugen Hoyos wrote:
> > Fixes ticket #4519.
> I will push this if there are no objections.

While trying to see if the proposed XV demuxer[1] can be simplified, I
tripped over the fact that this KUX patch introduces a new demuxer for
what looks like "only" a minor variant of FLV. Could the patch not just
as well extend the flv probe and the extension list?

Of course, this would need to be implemented differently (perhaps a
flag within the Class?):

> if(!strcmp(s->iformat->name, "kux"))

Or is the difference between "a variant" and "a demuxer of its own" too
small to justify the former? Just wondering.

And I personally would have only bumped micro, not minor, but that's
just a gut feeling, I haven't checked what is usually done.

Cheers,
Moritz

P.S.: I will subsequently propose a similar initial XV patch. Either as
this KUX patch does, or as I suggested above.

[1] http://ffmpeg.org/pipermail/ffmpeg-devel/2019-March/241483.html


More information about the ffmpeg-devel mailing list