[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

Nick Renieris velocityra at gmail.com
Wed Mar 20 17:03:18 EET 2019


Στις Τετ, 20 Μαρ 2019 στις 4:17 μ.μ., ο/η Paul B Mahol
<onemda at gmail.com> έγραψε:
> DNG I posted should be decodeable by default, without need for extra option(s).

The DNG contents themselves? As in, not just the thumbnail? That's
what the whole GSoC proposal is about though... What about:
>On Tue, Mar 19, 2019 at 03:03:20AM +0200, Nick Renieris wrote:
>Not to mention, this patch is for preliminary support, I don't suppose you require a massive patchset that implements everything altogether? Besides, GSoC requirements state that I need to get a minor patch in, before I can even apply. This is what this patch is for.

> The subimage option is intended to decode Nth image as is stored in file.

Nth image? The option is a boolean.

_If_ it was an integer though:

Given what you said, for -thumbnail I would need to check for
NewSubfileType's Bit0==1 and for -subimage, Bit1==1?
(Here's where I'm getting my info from so that we're on the same page:
https://www.awaresystems.be/imaging/tiff/tifftags/newsubfiletype.html)

But it's not an integer as far as I can see, so all of the above is
out of scope for this patch.

> The thumbnail option should be implemented to decode only first/best thumbnail.

Sounds easy enough.

> There is way to detect them and ignore them when not that option is set.

Detect/ignore the thumbnails? Yes, that's easy.


More information about the ffmpeg-devel mailing list