[FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

Vittorio Giovara vittorio.giovara at gmail.com
Tue Mar 19 16:23:08 EET 2019


On Tue, Mar 19, 2019 at 2:17 AM Sun, Jing A <jing.a.sun at intel.com> wrote:

> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of
> Jing SUN
> Sent: Monday, March 11, 2019 6:38 PM
> To: ffmpeg-devel at ffmpeg.org
> Cc: Sun, Jing A <jing.a.sun at intel.com>; Huang, Zhengxu <
> zhengxu.huang at intel.com>; Jun Zhao <jun.zhao at intel.com>; Tmar, Hassene <
> hassene.tmar at intel.com>
> Subject: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc
> encoder wrapper.
>
> From: Jing Sun <jing.a.sun at intel.com>
>
> base on patch by Huang, Zhengxu from https://github.com/intel/SVT-HEVC
>
> V4: - Fix the build error with new API in PR#52
>     - Fix the encoding hang issue by API change in PR#52
>     - Fix the last frame dropping issue
>     - Fix the invalid parameter causing segmentation fault issue
>     - Add the support to svt hevc and av1 plugins coexistance
>     - Add the VMAF optimized mode to "-tune"
>     - Add the "-hdr" parameter
>
> V3: - Fix the build error with new API
>
> V2: - Change the config options (didn't need to enable-gpl for BSD+Patent,
>       it's can compatible with LGPL2+, thanks Xavier correct this part),
>       now just need to "--enable-libsvthevc" option
>     - Add force_idr option
>     - Remove default GoP size setting in the wrapper, SVT-HEVC will calc
>       the the GoP size internal
>     - Refine the code as the FFmpeg community's comments
>       (https://patchwork.ffmpeg.org/patch/11347/)
>
> V1: - base on patch by Huang, Zhengxu, then refine some code.
>

all this version history should be in the email thread but not in the
commit section in my opinion


>
> Change-Id: If0dcc5044ab9effd6847a8f48797b985d02b0816
>

this id means nothing in ffmpeg git, I'd suggest dropping it


> Signed-off-by: Huang, Zhengxu <zhengxu.huang at intel.com>
> Signed-off-by: hassene <hassene.tmar at intel.com>
>

Should there be a real name here?


> Signed-off-by: Jun Zhao <jun.zhao at intel.com>
> Signed-off-by: Jing Sun <jing.a.sun at intel.com>
> Signed-off-by: Jing SUN <jing.a.sun at intel.com>
>

double sign-off?

---
>
[..]

> --
> 1.8.3.1
>
> Hi maintainers,
>
> A week has passed and no negative comment is received except a new feature
> request, which will be considered in the next version. Is the first version
> good to be picked?
>

Until that feature request is added, there should be a warning about that
missing missing feature IMO.
-- 
Vittorio


More information about the ffmpeg-devel mailing list