[FFmpeg-devel] [PATCHv3] avcodec/nvenc: Reconfigure resolution on-the-fly

Timo Rothenpieler timo at rothenpieler.org
Fri Mar 15 21:03:06 EET 2019


> So what's the final verdict here, can this be pushed or not?
> 
> Timo - did you manage to test it over last weekend?

I haven't found the time, sorry.
I'm generally not opposed to this. It does not disrupt normal use, and 
spinning up nvenc does have a surprisingly hefty overhead, so it makes 
sense to have features like that.

One request I'd have for the patch though, if one of the new max_ 
parameters is set, and dyn res changing is not supported, there should 
be an error.

Likewise if the res does change and max_width/height were not set.
Silently not doing anything seems bad.

Also, someone needs to ack the non-nvenc changes. Not sure if that 
explanation is really needed, since this is an nvenc specific edge case.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4538 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190315/f9f6c4ee/attachment.bin>


More information about the ffmpeg-devel mailing list