[FFmpeg-devel] [PATCH] apedec: add ability to check CRC

Hendrik Leppkes h.leppkes at gmail.com
Wed Mar 6 15:36:52 EET 2019


On Wed, Mar 6, 2019 at 2:18 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
> 2019-03-06 12:22 GMT+01:00, Lynne <dev at lynne.ee>:
> > The CRC flag is only signalled once every few minutes but CRC is still
> > always present so the patch uses the file version instead.
> > CRC on 24-bit files wants non-padded samples so skip such files.
> > Some corrupt samples may have been output before the final check
> > depending on the -max_samples setting.
>
> Imo, you should only return an error for some non-default
> strict value (it should be possible for the user to show the
> issue but continue to decode).
>

strict is the wrong value to check here. It could use err_recognition
& AV_EF_EXPLODE and only print otherwise.

- Hendrik


More information about the ffmpeg-devel mailing list