[FFmpeg-devel] [PATCH] ffmpeg: explicitly handle sub2video subpicture initialization

[Jan Ekström]

On Sun, Mar 3, 2019 at 6:03 PM Paul B Mahol <onemda at gmail.com> wrote:
>
> On 3/3/19, Jan Ekström <jeebjp at gmail.com> wrote:
> > On Tue, Feb 26, 2019 at 2:12 AM Jan Ekström <jeebjp at gmail.com> wrote:
> >>
> >> Each time the sub2video structure is initialized, the sub2video
> >> subpicture is initialized together with the first received heartbeat.
> >> The heartbeat's PTS is utilized as the subpicture start time.
> >>
> >> Additionally, add some documentation on the stages.
> >> ---
> >
> > Ping.
>
> Should be OK if it does not break something.
>

It fixes an untested use case that broke when fixing an unlimited
buffering bug the other week, reported by Michael
(https://ffmpeg.org/pipermail/ffmpeg-devel/2019-February/240398.html)
. It additionally doesn't resort to hard-coding the initial PTS value
to zero. I will try to make a test sample for this as well, so we can
catch this thing breaking through FATE.

So far in my testing it hasn't broken, but that said I mostly use
sub2video to overlay things on top of video.

Jan