[FFmpeg-devel] [PATCH] Added ff_v210_planar_unpack_aligned_avx2

Martin Vignali martin.vignali at gmail.com
Sun Mar 3 16:44:54 EET 2019


Hello,

Few comments.

You can use VBROADCASTI128 macro instead of changing the size of the
constants
(VBROADCASTI128 load 128 bit when using XMM, and broadcast the 128bit to
the two lane when using YMM)

The %if ARCH_X86_64 part, seems strange.
seems to only be useful for AVX2, not for sse/avx.

Not directly related to this patch, but it can be interesting for testing
purpose to write a checkasm test for the v210 func decoding.
So it's more easy to check the perf for "each" cpu flags, and be sure, the
various width cases works as expected.

Martin


More information about the ffmpeg-devel mailing list