[FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

[Andreas Håkon]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, 22 de April de 2019 14:17, mypopy at gmail.com <mypopy at gmail.com> wrote:

> On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong zhong.li at intel.com wrote:
>
> > > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> > > Of Andreas Håkon via ffmpeg-devel
> > > Sent: Thursday, April 18, 2019 6:11 PM
> > > To: FFmpeg development discussions and patches
> > > ffmpeg-devel at ffmpeg.org
> > > Cc: Andreas Håkon andreas.hakon at protonmail.com
> > > Subject: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with
> > > CO3 define
> > > Hi,
> > > In response to this ticket I provide the first part of the patch:
> > > https://trac.ffmpeg.org/ticket/7839
> > > This QSV_HAVE_GPB code needs to be protected by QSV_HAVE_CO3.
> > > Regards.
> > > A.H.
> >
> > Why it is must? It is impossible that QSV_HAVE_GPB is enabled but QSV_HAVE_CO3 is not enabled.
> > QSV_HAVE_GPB is enabled by MSDK API v1.18, but QSV_HAVE_CO3 is API V1.11.
>
> In the ticket, Andreas Håkon pointed out that it is "only as a
> temporary solution", so I think it's a workaround.

Hi mypopy,

My patch only resolves one part of the problem. It's not a temporary
solution, but a forgot in the original code.

I feel Mr. Zhong needs to fix the "mpeg2_qsv" encoder. But this simple
patch can help with the "temporary solution" of disable QVBR in the code.
In any case, this patch needs to be merged.

Regards.
A.H.

---