[FFmpeg-devel] [PATCH 1/2] libavcodec/zmbv: change 24-bit decoder channel order, from RGB24 to BGR24

Matthew Fearnley matthew.w.fearnley at gmail.com
Tue Apr 2 23:16:51 EEST 2019



> On 2 Apr 2019, at 16:48, Tomas Härdin <tjoppen at acc.umu.se> wrote:
> 
> mån 2019-04-01 klockan 13:29 +0100 skrev Matthew Fearnley:
>>>>> On 1 Apr 2019, at 10:28, Tomas Härdin <tjoppen at acc.umu.se> wrote:
>>> 
>>> fre 2019-03-29 klockan 22:23 +0000 skrev Matthew Fearnley:
>>>>>> On Wed, 27 Mar 2019 at 09:42, Tomas Härdin <tjoppen at acc.umu.se> wrote:
>>>>>> Additional minor fix: use PTRDIFF_SPECIFIER for `src - c->decomp_buf`.
>>>>>> Other bit depths saw this change in ced0d6c14d, but this instance was
>>>>>> missed, presumably because of the #ifdef block.
>>>>> 
>>>>> I think it'd be best to split this off into its own patch, even if it's
>>>>> trivial
>>>>> 
>>>> 
>>>> Yeah, I think you're right.
>>>> I'm attaching two patches here, if that works..
>>> 
>>> You got the commit messages mixed up :) Otherwise they look OK
>> 
>> Doh!
>> Do I need to correct that, or is it easy enough for you to fix up manually?
> 
> Fixed and pushed.
Thanks so much.
By the way, is there a recommended way to enable #ifdef blocks when building ffmpeg? I’ve been adding #defines of the top of the source file, which does the job, but it feels like a bit of a kludge from a source-control perspective.
> 
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list