[FFmpeg-devel] [PATCH] libavformat/http: Fix memory leak in get_cookies.

Richard Shaffer rshaffer at tunein.com
Tue Apr 17 20:48:16 EEST 2018


On Fri, Apr 13, 2018 at 4:42 PM, <rshaffer at tunein.com> wrote:

> From: Richard Shaffer <rshaffer at tunein.com>
>
> ---
>  libavformat/http.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 983034f083..b4a1919f24 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -1103,6 +1103,7 @@ static int get_cookies(HTTPContext *s, char
> **cookies, const char *path,
>              snprintf(*cookies, str_size, "%s; %s=%s", tmp,
> cookie_entry->key, cookie_entry->value);
>              av_free(tmp);
>          }
> +        av_dict_free(&cookie_params);
>      }
>
>      av_free(set_cookies);
> --
> 2.15.1 (Apple Git-101)
>
> Would one of the maintainers mind looking at and applying this? It's a
one-line change to fix a memory leak.

Thanks,

-Richard


More information about the ffmpeg-devel mailing list