[FFmpeg-devel] [PATCH] compat/atomics/gcc: use __typeof__ instead of typeof

[wm4]

On Sat, 18 Mar 2017 13:39:34 +0700
Muhammad Faiz <mfcc64 at gmail.com> wrote:

> On Sat, Mar 18, 2017 at 5:31 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > 2017-03-17 19:46 GMT+01:00 James Almer <jamrial at gmail.com>:  
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>  compat/atomics/gcc/stdatomic.h | 8 ++++----
> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/compat/atomics/gcc/stdatomic.h b/compat/atomics/gcc/stdatomic.h
> >> index 41caddec5c..2b64687437 100644
> >> --- a/compat/atomics/gcc/stdatomic.h
> >> +++ b/compat/atomics/gcc/stdatomic.h
> >> @@ -100,8 +100,8 @@ do {                                    \
> >>
> >>  #define atomic_exchange(object, desired)                            \
> >>  ({                                                                  \
> >> -    typeof(object) _obj = (object);                                 \
> >> -    typeof(*object) _old;                                           \
> >> +    __typeof__(object) _obj = (object);                             \
> >> +    __typeof__(*object) _old;                                       \  
> >
> > Maybe mention why this is a good idea?  
> 
> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-March/208000.html
> 
> LGTM
> Thank's

I think he knows the reason, but wants the patch author to mention it in
the commit message.