[FFmpeg-devel] [PATCH 3/3] ffmpeg, ffprobe: don't "merge" side data into packet data by default

wm4 nfxjfg at googlemail.com
Fri Mar 10 16:45:43 EET 2017


On Fri, 10 Mar 2017 15:29:17 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> Hi
> 
> On Thu, Mar 09, 2017 at 03:45:19PM +0100, wm4 wrote:
> > Preparation for potentially disabling merged side data by default in the
> > libs. Do this in particular because it affects fate tests.
> > 
> > The changed tests either reflect added packet side data, or the changed
> > packet size due to merged side data removal reducing the packet size.
> > 
> > The previous patches are needed because there is apparently no other way
> > for ffmpeg.c to pass the flag down to sub demuxers without potentially
> > overriding command line settings.
> > ---
> >  ffmpeg_opt.c                                  |   2 +
> >  ffprobe.c                                     |   8 ++
> >  libavformat/tests/seek.c                      |   2 +
> >  tests/ref/fate/concat-demuxer-simple2-lavf-ts | 192 +++++++++++++++++---------
> >  tests/ref/fate/gaplessenc-itunes-to-ipod-aac  |   4 +-
> >  tests/ref/fate/gaplessenc-pcm-to-mov-aac      |   4 +-
> >  tests/ref/fate/gaplessinfo-itunes1            |   4 +-
> >  tests/ref/fate/gaplessinfo-itunes2            |   4 +-
> >  tests/ref/fate/mov-aac-2048-priming           |   3 +-
> >  tests/ref/seek/cache-pipe                     |  10 +-
> >  tests/ref/seek/extra-mp3                      |  18 +--
> >  tests/ref/seek/lavf-ts                        |  54 ++++----
> >  tests/ref/seek/mkv-codec-delay                |  14 +-
> >  13 files changed, 198 insertions(+), 121 deletions(-)  
> 
> just wanted to say that iam not sure i will have time to test this
> in the near future, thus others should review / approve
> 
> saying so theres no misunderstanding if i dont reply with an approval
> or tested-by 
> 
> sorry & thx

OK, then I'll push on Monday.


More information about the ffmpeg-devel mailing list